Commit 4b747079 authored by Ryan C. Thompson's avatar Ryan C. Thompson

Update emacsmirror method for github method cleanup

Now it add a :pkgname property instead of just adding ":username
emacsmirror".

Also update the tests for the Github method
parent 188cee10
......@@ -20,7 +20,8 @@
"Return a github-type source equivalent to emacsmirror PACKAGE."
(assert (equal (el-get-package-type package) 'emacsmirror) nil
"Need an emacsmirror package")
(append '(:type github :username "emacsmirror")
(append `(:type github
:pkgname ,(format "emacsmirror/%s" package))
(el-get-package-def package)))
;;
......
......@@ -5,18 +5,38 @@
(setq debug-on-error t
el-get-verbose t)
;; Install a github-type recipe
(el-get 'sync 'window-layout)
;; Install an emacsmirror-type recipe
(el-get 'sync 'dired-plus)
(condition-case nil
(error "THROW")
(error (message "Caught an error")))
;; ;; Install a github-type recipe
;; (el-get 'sync 'window-layout)
;; ;; Install an emacsmirror-type recipe
;; (el-get 'sync 'dired-plus)
;; Try to install a recipe for a nonexistent github repo
(condition-case err
(progn
;; Should fail
(let ((el-get-sources
'((:name valid-recipe-for-nonexistent-repo
:pkgname "xjklfjdlfs/fdjsklfdsj"
:type github)))
;; This seems to escape error handlers when
;; `debug-on-error' is t.
(debug-on-error nil))
(el-get 'sync 'valid-recipe-for-nonexistent-repo))
(signal 'test-failure
'("The package \"valid-recipe-for-nonexistent-repo\" should have caused an error, but it didn't.")))
(error (message "Installing \"valid-recipe-for-nonexistent-repo\" failed as expected. The error message was: %S" err)))
(condition-case err
(progn
;; Should fail
(let ((el-get-sources
'((:name broken-pkg
'((:name broken-github-recipe
:type github))))
(el-get 'sync 'broken-pkg))
(el-get 'sync 'broken-github-recipe))
(signal 'test-failure
'("The package\"broken-pkg\" should have caused an error, but it didn't.")))
(error (message "Installing \"broken-pkg\" failed as expected. The error message was: %S" err)))
'("The package \"broken-github-recipe\" should have caused an error, but it didn't.")))
(error (message "Installing \"broken-github-recipe\" failed as expected. The error message was: %S" err)))
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment